Skip to content

Merge here the split branch #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Dec 1, 2024
Merged

Merge here the split branch #84

merged 16 commits into from
Dec 1, 2024

Conversation

santiagocasas
Copy link
Owner

@santiagocasas santiagocasas commented Dec 1, 2024 •
edited
Loading

Fixes #

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@santiagocasas santiagocasas self-assigned this Dec 1, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.59375% with 53 lines in your changes missing coverage. Please review.

Project coverage is 35.70%. Comparing base (b487397) to head (7b55377).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cosmicfishpie/fishermatrix/cosmicfish.py 4.00% 24 Missing ⚠️
cosmicfishpie/LSSsurvey/photo_cov.py 64.00% 9 Missing ⚠️
cosmicfishpie/LSSsurvey/photo_obs.py 70.37% 8 Missing ⚠️
cosmicfishpie/configs/config.py 58.82% 7 Missing ⚠️
cosmicfishpie/cosmology/nuisance.py 66.66% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   35.53%   35.70%   +0.16%     
==========================================
  Files          29       29              
  Lines        5344     5406      +62     
==========================================
+ Hits         1899     1930      +31     
- Misses       3445     3476      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

santiagocasas
santiagocasas commented Dec 1, 2024
View reviewed changes
Copy link
Owner Author

@santiagocasas santiagocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@santiagocasas santiagocasas merged commit 311699a into main Dec 1, 2024
10 checks passed
@santiagocasas
Copy link
Owner Author

merging several branches

@santiagocasas santiagocasas deleted the merge_here_splits branch December 1, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@santiagocasas santiagocasas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@santiagocasas @codecov-commenter